提交 a6a9a5da 编写于 作者: M Miaoqian Lin 提交者: Joerg Roedel

iommu: Fix refcount leak in iommu_device_claim_dma_owner

iommu_group_get() returns the group with the reference incremented.
Move iommu_group_get() after owner check to fix the refcount leak.

Fixes: 89395cce ("iommu: Add device-centric DMA ownership interfaces")
Signed-off-by: NMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: NLu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: NJason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20221230083100.1489569-1-linmq006@gmail.com
[ joro: Remove *group = NULL initialization ]
Signed-off-by: NJoerg Roedel <jroedel@suse.de>
上级 32ea2c57
...@@ -3185,14 +3185,16 @@ EXPORT_SYMBOL_GPL(iommu_group_claim_dma_owner); ...@@ -3185,14 +3185,16 @@ EXPORT_SYMBOL_GPL(iommu_group_claim_dma_owner);
*/ */
int iommu_device_claim_dma_owner(struct device *dev, void *owner) int iommu_device_claim_dma_owner(struct device *dev, void *owner)
{ {
struct iommu_group *group = iommu_group_get(dev); struct iommu_group *group;
int ret = 0; int ret = 0;
if (!group)
return -ENODEV;
if (WARN_ON(!owner)) if (WARN_ON(!owner))
return -EINVAL; return -EINVAL;
group = iommu_group_get(dev);
if (!group)
return -ENODEV;
mutex_lock(&group->mutex); mutex_lock(&group->mutex);
if (group->owner_cnt) { if (group->owner_cnt) {
if (group->owner != owner) { if (group->owner != owner) {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册