提交 a2e78cf7 编写于 作者: M Marc Kleine-Budde

can: slcan: don't touch skb after netif_rx_ni()

There is no guarantee that the skb is in the same state after calling
net_receive_skb() or netif_rx(). It might be freed or reused. Not really
harmful as its a read access, except you turn on the proper debugging options
which catch a use after free.

Cc: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: NMarc Kleine-Budde <mkl@pengutronix.de>
上级 83537b6f
...@@ -218,10 +218,10 @@ static void slc_bump(struct slcan *sl) ...@@ -218,10 +218,10 @@ static void slc_bump(struct slcan *sl)
memcpy(skb_put(skb, sizeof(struct can_frame)), memcpy(skb_put(skb, sizeof(struct can_frame)),
&cf, sizeof(struct can_frame)); &cf, sizeof(struct can_frame));
netif_rx_ni(skb);
sl->dev->stats.rx_packets++; sl->dev->stats.rx_packets++;
sl->dev->stats.rx_bytes += cf.can_dlc; sl->dev->stats.rx_bytes += cf.can_dlc;
netif_rx_ni(skb);
} }
/* parse tty input stream */ /* parse tty input stream */
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册