提交 a0d21ba1 编写于 作者: G Gustavo A. R. Silva 提交者: Bjorn Helgaas

PCI: dra7xx: Propagate platform_get_irq() errors in dra7xx_pcie_probe()

platform_get_irq() returns an error code, but the pci-dra7xx driver ignores
it and always returns -EINVAL. This is not correct and prevents
-EPROBE_DEFER from being propagated properly.

Print and propagate the return value of platform_get_irq() on failure.

This issue was detected with the help of Coccinelle.
Signed-off-by: NGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: NBjorn Helgaas <bhelgaas@google.com>
Acked-by: NKishon Vijay Abraham I <kishon@ti.com>
上级 61534d1a
...@@ -616,8 +616,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev) ...@@ -616,8 +616,8 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0); irq = platform_get_irq(pdev, 0);
if (irq < 0) { if (irq < 0) {
dev_err(dev, "missing IRQ resource\n"); dev_err(dev, "missing IRQ resource: %d\n", irq);
return -EINVAL; return irq;
} }
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ti_conf"); res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ti_conf");
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册