提交 a0640925 编写于 作者: J Jamie Iles 提交者: Dmitry Torokhov

Input: tnetv107x-keypad - don't treat NULL clk as an error

We should use IS_ERR() when checking whether clk_get() succeeded or
not since it returns errors by encoding error codes with ERR_PTR().
Signed-off-by: NJamie Iles <jamie@jamieiles.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>
上级 01c728a2
...@@ -14,6 +14,7 @@ ...@@ -14,6 +14,7 @@
*/ */
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/err.h>
#include <linux/errno.h> #include <linux/errno.h>
#include <linux/input.h> #include <linux/input.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
...@@ -219,9 +220,9 @@ static int __devinit keypad_probe(struct platform_device *pdev) ...@@ -219,9 +220,9 @@ static int __devinit keypad_probe(struct platform_device *pdev)
} }
kp->clk = clk_get(dev, NULL); kp->clk = clk_get(dev, NULL);
if (!kp->clk) { if (IS_ERR(kp->clk)) {
dev_err(dev, "cannot claim device clock\n"); dev_err(dev, "cannot claim device clock\n");
error = -EINVAL; error = PTR_ERR(kp->clk);
goto error_clk; goto error_clk;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册