提交 9e866e5d 编写于 作者: E Egil Hjelmeland 提交者: David S. Miller

net: dsa: lan9303: Renamed indirect phy access functions

Preparing for the following fix of MDIO phy access:

Renamed functions that access PHY 1 and 2 indirectly through PMI
registers.

 lan9303_port_phy_reg_wait_for_completion() to
 lan9303_indirect_phy_wait_for_completion()

 lan9303_port_phy_reg_read() to
 lan9303_indirect_phy_read()

 lan9303_port_phy_reg_write() to
 lan9303_indirect_phy_write()

Also changed "val" parameter of lan9303_indirect_phy_write() to u16,
for clarity.
Signed-off-by: NEgil Hjelmeland <privat@egil-hjelmeland.no>
Reviewed-by: NAndrew Lunn <andrew@lunn.ch>
Reviewed-by: NVivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: NFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 ab78acb1
...@@ -248,7 +248,7 @@ static int lan9303_virt_phy_reg_write(struct lan9303 *chip, int regnum, u16 val) ...@@ -248,7 +248,7 @@ static int lan9303_virt_phy_reg_write(struct lan9303 *chip, int regnum, u16 val)
return regmap_write(chip->regmap, LAN9303_VIRT_PHY_BASE + regnum, val); return regmap_write(chip->regmap, LAN9303_VIRT_PHY_BASE + regnum, val);
} }
static int lan9303_port_phy_reg_wait_for_completion(struct lan9303 *chip) static int lan9303_indirect_phy_wait_for_completion(struct lan9303 *chip)
{ {
int ret, i; int ret, i;
u32 reg; u32 reg;
...@@ -268,7 +268,7 @@ static int lan9303_port_phy_reg_wait_for_completion(struct lan9303 *chip) ...@@ -268,7 +268,7 @@ static int lan9303_port_phy_reg_wait_for_completion(struct lan9303 *chip)
return -EIO; return -EIO;
} }
static int lan9303_port_phy_reg_read(struct lan9303 *chip, int addr, int regnum) static int lan9303_indirect_phy_read(struct lan9303 *chip, int addr, int regnum)
{ {
int ret; int ret;
u32 val; u32 val;
...@@ -278,7 +278,7 @@ static int lan9303_port_phy_reg_read(struct lan9303 *chip, int addr, int regnum) ...@@ -278,7 +278,7 @@ static int lan9303_port_phy_reg_read(struct lan9303 *chip, int addr, int regnum)
mutex_lock(&chip->indirect_mutex); mutex_lock(&chip->indirect_mutex);
ret = lan9303_port_phy_reg_wait_for_completion(chip); ret = lan9303_indirect_phy_wait_for_completion(chip);
if (ret) if (ret)
goto on_error; goto on_error;
...@@ -287,7 +287,7 @@ static int lan9303_port_phy_reg_read(struct lan9303 *chip, int addr, int regnum) ...@@ -287,7 +287,7 @@ static int lan9303_port_phy_reg_read(struct lan9303 *chip, int addr, int regnum)
if (ret) if (ret)
goto on_error; goto on_error;
ret = lan9303_port_phy_reg_wait_for_completion(chip); ret = lan9303_indirect_phy_wait_for_completion(chip);
if (ret) if (ret)
goto on_error; goto on_error;
...@@ -305,8 +305,8 @@ static int lan9303_port_phy_reg_read(struct lan9303 *chip, int addr, int regnum) ...@@ -305,8 +305,8 @@ static int lan9303_port_phy_reg_read(struct lan9303 *chip, int addr, int regnum)
return ret; return ret;
} }
static int lan9303_phy_reg_write(struct lan9303 *chip, int addr, int regnum, static int lan9303_indirect_phy_write(struct lan9303 *chip, int addr,
unsigned int val) int regnum, u16 val)
{ {
int ret; int ret;
u32 reg; u32 reg;
...@@ -317,7 +317,7 @@ static int lan9303_phy_reg_write(struct lan9303 *chip, int addr, int regnum, ...@@ -317,7 +317,7 @@ static int lan9303_phy_reg_write(struct lan9303 *chip, int addr, int regnum,
mutex_lock(&chip->indirect_mutex); mutex_lock(&chip->indirect_mutex);
ret = lan9303_port_phy_reg_wait_for_completion(chip); ret = lan9303_indirect_phy_wait_for_completion(chip);
if (ret) if (ret)
goto on_error; goto on_error;
...@@ -435,7 +435,7 @@ static int lan9303_detect_phy_setup(struct lan9303 *chip) ...@@ -435,7 +435,7 @@ static int lan9303_detect_phy_setup(struct lan9303 *chip)
* 0x0000, which means 'phy_addr_sel_strap' is 1 and the IDs are 1-2-3. * 0x0000, which means 'phy_addr_sel_strap' is 1 and the IDs are 1-2-3.
* 0xffff is returned on MDIO read with no response. * 0xffff is returned on MDIO read with no response.
*/ */
reg = lan9303_port_phy_reg_read(chip, 3, MII_LAN911X_SPECIAL_MODES); reg = lan9303_indirect_phy_read(chip, 3, MII_LAN911X_SPECIAL_MODES);
if (reg < 0) { if (reg < 0) {
dev_err(chip->dev, "Failed to detect phy config: %d\n", reg); dev_err(chip->dev, "Failed to detect phy config: %d\n", reg);
return reg; return reg;
...@@ -726,7 +726,7 @@ static int lan9303_phy_read(struct dsa_switch *ds, int phy, int regnum) ...@@ -726,7 +726,7 @@ static int lan9303_phy_read(struct dsa_switch *ds, int phy, int regnum)
if (phy > phy_base + 2) if (phy > phy_base + 2)
return -ENODEV; return -ENODEV;
return lan9303_port_phy_reg_read(chip, phy, regnum); return lan9303_indirect_phy_read(chip, phy, regnum);
} }
static int lan9303_phy_write(struct dsa_switch *ds, int phy, int regnum, static int lan9303_phy_write(struct dsa_switch *ds, int phy, int regnum,
...@@ -740,7 +740,7 @@ static int lan9303_phy_write(struct dsa_switch *ds, int phy, int regnum, ...@@ -740,7 +740,7 @@ static int lan9303_phy_write(struct dsa_switch *ds, int phy, int regnum,
if (phy > phy_base + 2) if (phy > phy_base + 2)
return -ENODEV; return -ENODEV;
return lan9303_phy_reg_write(chip, phy, regnum, val); return lan9303_indirect_phy_write(chip, phy, regnum, val);
} }
static int lan9303_port_enable(struct dsa_switch *ds, int port, static int lan9303_port_enable(struct dsa_switch *ds, int port,
...@@ -773,13 +773,13 @@ static void lan9303_port_disable(struct dsa_switch *ds, int port, ...@@ -773,13 +773,13 @@ static void lan9303_port_disable(struct dsa_switch *ds, int port,
switch (port) { switch (port) {
case 1: case 1:
lan9303_disable_packet_processing(chip, LAN9303_PORT_1_OFFSET); lan9303_disable_packet_processing(chip, LAN9303_PORT_1_OFFSET);
lan9303_phy_reg_write(chip, chip->phy_addr_sel_strap + 1, lan9303_indirect_phy_write(chip, chip->phy_addr_sel_strap + 1,
MII_BMCR, BMCR_PDOWN); MII_BMCR, BMCR_PDOWN);
break; break;
case 2: case 2:
lan9303_disable_packet_processing(chip, LAN9303_PORT_2_OFFSET); lan9303_disable_packet_processing(chip, LAN9303_PORT_2_OFFSET);
lan9303_phy_reg_write(chip, chip->phy_addr_sel_strap + 2, lan9303_indirect_phy_write(chip, chip->phy_addr_sel_strap + 2,
MII_BMCR, BMCR_PDOWN); MII_BMCR, BMCR_PDOWN);
break; break;
default: default:
dev_dbg(chip->dev, dev_dbg(chip->dev,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册