提交 99a6993a 编写于 作者: J Jian Shen 提交者: David S. Miller

net: hns3: cleanup of return values in hclge_init_client_instance()

Removes the goto and directly returns in case of errors as part of the
cleanup.
Signed-off-by: NJian Shen <shenjian15@huawei.com>
Signed-off-by: NPeng Li <lipeng321@huawei.com>
Signed-off-by: NSalil Mehta <salil.mehta@huawei.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 e63cd65f
......@@ -5297,7 +5297,7 @@ static int hclge_init_client_instance(struct hnae3_client *client,
vport->nic.client = client;
ret = client->ops->init_instance(&vport->nic);
if (ret)
goto err;
return ret;
if (hdev->roce_client &&
hnae3_dev_roce_supported(hdev)) {
......@@ -5305,11 +5305,11 @@ static int hclge_init_client_instance(struct hnae3_client *client,
ret = hclge_init_roce_base_info(vport);
if (ret)
goto err;
return ret;
ret = rc->ops->init_instance(&vport->roce);
if (ret)
goto err;
return ret;
}
break;
......@@ -5319,7 +5319,7 @@ static int hclge_init_client_instance(struct hnae3_client *client,
ret = client->ops->init_instance(&vport->nic);
if (ret)
goto err;
return ret;
break;
case HNAE3_CLIENT_ROCE:
......@@ -5331,18 +5331,16 @@ static int hclge_init_client_instance(struct hnae3_client *client,
if (hdev->roce_client && hdev->nic_client) {
ret = hclge_init_roce_base_info(vport);
if (ret)
goto err;
return ret;
ret = client->ops->init_instance(&vport->roce);
if (ret)
goto err;
return ret;
}
}
}
return 0;
err:
return ret;
}
static void hclge_uninit_client_instance(struct hnae3_client *client,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册