提交 93aaba85 编写于 作者: D Dafna Hirschfeld 提交者: Mauro Carvalho Chehab

media: staging: rkisp1: params: in the isr, return if buffer list is empty

Currently the code in the isr checks if the buffer list is not
empty before referencing a buffer and then check again if the
buffer is not NULL. Instead we can save one 'if' statement by
returning if the buffers list is empty.
Also remove non-helpful inline doc 'get one empty buffer'
Signed-off-by: NDafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: NHelen Koike <helen.koike@collabora.com>
Signed-off-by: NHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: NMauro Carvalho Chehab <mchehab+huawei@kernel.org>
上级 b1b2715e
......@@ -1198,16 +1198,14 @@ void rkisp1_params_isr(struct rkisp1_device *rkisp1)
return;
}
/* get one empty buffer */
if (!list_empty(&params->params))
cur_buf = list_first_entry(&params->params,
struct rkisp1_buffer, queue);
if (!cur_buf) {
if (list_empty(&params->params)) {
spin_unlock(&params->config_lock);
return;
}
cur_buf = list_first_entry(&params->params,
struct rkisp1_buffer, queue);
new_params = (struct rkisp1_params_cfg *)(cur_buf->vaddr);
rkisp1_isp_isr_other_config(params, new_params);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册