提交 92f4ffec 编写于 作者: M Marek Behún 提交者: Lorenzo Pieralisi

PCI: aardvark: Update comment about link going down after link-up

Update the comment about what happens when link goes down after we have
checked for link-up. If a PIO request is done while link-down, we have
a serious problem.

Link: https://lore.kernel.org/r/20220110015018.26359-23-kabel@kernel.orgSigned-off-by: NMarek Behún <kabel@kernel.org>
Signed-off-by: NLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
上级 0c36ab43
...@@ -998,8 +998,12 @@ static bool advk_pcie_valid_device(struct advk_pcie *pcie, struct pci_bus *bus, ...@@ -998,8 +998,12 @@ static bool advk_pcie_valid_device(struct advk_pcie *pcie, struct pci_bus *bus,
return false; return false;
/* /*
* If the link goes down after we check for link-up, nothing bad * If the link goes down after we check for link-up, we have a problem:
* happens but the config access times out. * if a PIO request is executed while link-down, the whole controller
* gets stuck in a non-functional state, and even after link comes up
* again, PIO requests won't work anymore, and a reset of the whole PCIe
* controller is needed. Therefore we need to prevent sending PIO
* requests while the link is down.
*/ */
if (!pci_is_root_bus(bus) && !advk_pcie_link_up(pcie)) if (!pci_is_root_bus(bus) && !advk_pcie_link_up(pcie))
return false; return false;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册