提交 91aeaf09 编写于 作者: P Ping-Ke Shih 提交者: Kalle Valo

rtw88: fix multiple definition of rtw_pm_ops

'const struct dev_pm_ops rtw_pm_ops' is declared by pci.c, and it should be
declare as 'extern' in pci.h. Without 'extern' causes every file including
pci.h has an individual instance of rtw_pm_ops but not reference to the one
declared in pci.c

If kernel config, like test robot, doesn't build driver as module, it leads
multiple definition.
Reported-by: Nkernel test robot <lkp@intel.com>
Fixes: 2e86ef41 ("rtw88: pci: Add prototypes for .probe, .remove and .shutdown")
Signed-off-by: NPing-Ke Shih <pkshih@realtek.com>
Signed-off-by: NKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201208013746.11065-1-pkshih@realtek.com
上级 5c455c5a
......@@ -214,7 +214,7 @@ struct rtw_pci {
void __iomem *mmap;
};
const struct dev_pm_ops rtw_pm_ops;
extern const struct dev_pm_ops rtw_pm_ops;
int rtw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id);
void rtw_pci_remove(struct pci_dev *pdev);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册