提交 8c7f5f58 编写于 作者: L Lars-Peter Clausen 提交者: Dmitry Torokhov

Input: pxa27x_keypad - pass correct pointer to free_irq()

free_irq() expects the same pointer that was passed to request_irq(),
otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
上级 d7ecfff1
...@@ -582,7 +582,7 @@ static int pxa27x_keypad_probe(struct platform_device *pdev) ...@@ -582,7 +582,7 @@ static int pxa27x_keypad_probe(struct platform_device *pdev)
return 0; return 0;
failed_free_irq: failed_free_irq:
free_irq(irq, pdev); free_irq(irq, keypad);
failed_put_clk: failed_put_clk:
clk_put(keypad->clk); clk_put(keypad->clk);
failed_free_io: failed_free_io:
...@@ -600,7 +600,7 @@ static int pxa27x_keypad_remove(struct platform_device *pdev) ...@@ -600,7 +600,7 @@ static int pxa27x_keypad_remove(struct platform_device *pdev)
struct pxa27x_keypad *keypad = platform_get_drvdata(pdev); struct pxa27x_keypad *keypad = platform_get_drvdata(pdev);
struct resource *res; struct resource *res;
free_irq(keypad->irq, pdev); free_irq(keypad->irq, keypad);
clk_put(keypad->clk); clk_put(keypad->clk);
input_unregister_device(keypad->input_dev); input_unregister_device(keypad->input_dev);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册