提交 8c7e7b84 编写于 作者: D Dan Carpenter 提交者: Martin K. Petersen

scsi: libsas: Use _safe() loop in sas_resume_port()

If sas_notify_lldd_dev_found() fails then this code calls:

	sas_unregister_dev(port, dev);

which removes "dev", our list iterator, from the list.  This could lead to
an endless loop.  We need to use list_for_each_entry_safe().

Link: https://lore.kernel.org/r/YKUeq6gwfGcvvhty@mwanda
Fixes: 303694ee ("[SCSI] libsas: suspend / resume support")
Reviewed-by: NJohn Garry <john.garry@huawei.com>
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
上级 b4150b68
...@@ -25,7 +25,7 @@ static bool phy_is_wideport_member(struct asd_sas_port *port, struct asd_sas_phy ...@@ -25,7 +25,7 @@ static bool phy_is_wideport_member(struct asd_sas_port *port, struct asd_sas_phy
static void sas_resume_port(struct asd_sas_phy *phy) static void sas_resume_port(struct asd_sas_phy *phy)
{ {
struct domain_device *dev; struct domain_device *dev, *n;
struct asd_sas_port *port = phy->port; struct asd_sas_port *port = phy->port;
struct sas_ha_struct *sas_ha = phy->ha; struct sas_ha_struct *sas_ha = phy->ha;
struct sas_internal *si = to_sas_internal(sas_ha->core.shost->transportt); struct sas_internal *si = to_sas_internal(sas_ha->core.shost->transportt);
...@@ -44,7 +44,7 @@ static void sas_resume_port(struct asd_sas_phy *phy) ...@@ -44,7 +44,7 @@ static void sas_resume_port(struct asd_sas_phy *phy)
* 1/ presume every device came back * 1/ presume every device came back
* 2/ force the next revalidation to check all expander phys * 2/ force the next revalidation to check all expander phys
*/ */
list_for_each_entry(dev, &port->dev_list, dev_list_node) { list_for_each_entry_safe(dev, n, &port->dev_list, dev_list_node) {
int i, rc; int i, rc;
rc = sas_notify_lldd_dev_found(dev); rc = sas_notify_lldd_dev_found(dev);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册