提交 8c6ae461 编写于 作者: A Alexey Khoroshilov 提交者: Jakub Kicinski

net: dsa: lantiq_gswip: fix use after free in gswip_remove()

of_node_put(priv->ds->slave_mii_bus->dev.of_node) should be
done before mdiobus_free(priv->ds->slave_mii_bus).
Signed-off-by: NAlexey Khoroshilov <khoroshilov@ispras.ru>
Fixes: 0d120dfb ("net: dsa: lantiq_gswip: don't use devres for mdiobus")
Reviewed-by: NAndrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/1644921768-26477-1-git-send-email-khoroshilov@ispras.ruSigned-off-by: NJakub Kicinski <kuba@kernel.org>
上级 0b0dff5b
...@@ -2176,8 +2176,8 @@ static int gswip_remove(struct platform_device *pdev) ...@@ -2176,8 +2176,8 @@ static int gswip_remove(struct platform_device *pdev)
if (priv->ds->slave_mii_bus) { if (priv->ds->slave_mii_bus) {
mdiobus_unregister(priv->ds->slave_mii_bus); mdiobus_unregister(priv->ds->slave_mii_bus);
mdiobus_free(priv->ds->slave_mii_bus);
of_node_put(priv->ds->slave_mii_bus->dev.of_node); of_node_put(priv->ds->slave_mii_bus->dev.of_node);
mdiobus_free(priv->ds->slave_mii_bus);
} }
for (i = 0; i < priv->num_gphy_fw; i++) for (i = 0; i < priv->num_gphy_fw; i++)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册