提交 883f50ea 编写于 作者: O Olivier Moysan 提交者: Jonathan Cameron

iio: adc: stm32-adc: disable adc before calibration

The calibration is launched from prepare callback.
The ADC state when entering this function may be unknown as the
ADC may have been left enabled by boot stage.
One prerequisite for ADC calibration is to have ADC in disabled state.
If the calibration is started when ADC is still enabled, the behavior is
unpredictable, and the calibration may fail with a timeout error.

Force ADC to disabled state in stm32h7_adc_selfcalib().
ADC enabling is ensured by stm32h7_adc_enable() call,
before leaving prepare callback.
Signed-off-by: NOlivier Moysan <olivier.moysan@foss.st.com>
Reviewed-by: NFabrice Gasnier <fabrice.gasnier@foss.st.com>
Link: https://lore.kernel.org/r/20220620154738.801706-3-olivier.moysan@foss.st.comSigned-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>
上级 cf59ad96
...@@ -1019,6 +1019,9 @@ static int stm32h7_adc_selfcalib(struct iio_dev *indio_dev) ...@@ -1019,6 +1019,9 @@ static int stm32h7_adc_selfcalib(struct iio_dev *indio_dev)
if (adc->cal.calibrated) if (adc->cal.calibrated)
return true; return true;
/* ADC must be disabled for calibration */
stm32h7_adc_disable(indio_dev);
/* /*
* Select calibration mode: * Select calibration mode:
* - Offset calibration for single ended inputs * - Offset calibration for single ended inputs
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册