提交 8673ef7b 编写于 作者: A Andy Shevchenko 提交者: Greg Kroah-Hartman

tty: rpmsg: Use dev_err_probe() in ->probe()

It's fine to use dev_err_probe() in ->probe() even if we know
it won't be deferred.
Signed-off-by: NAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20211025135148.53944-3-andriy.shevchenko@linux.intel.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
上级 408a5079
...@@ -153,10 +153,8 @@ static int rpmsg_tty_probe(struct rpmsg_device *rpdev) ...@@ -153,10 +153,8 @@ static int rpmsg_tty_probe(struct rpmsg_device *rpdev)
int ret; int ret;
cport = rpmsg_tty_alloc_cport(); cport = rpmsg_tty_alloc_cport();
if (IS_ERR(cport)) { if (IS_ERR(cport))
dev_err(dev, "Failed to alloc tty port\n"); return dev_err_probe(dev, PTR_ERR(cport), "Failed to alloc tty port\n");
return PTR_ERR(cport);
}
tty_port_init(&cport->port); tty_port_init(&cport->port);
cport->port.ops = &rpmsg_tty_port_ops; cport->port.ops = &rpmsg_tty_port_ops;
...@@ -164,9 +162,8 @@ static int rpmsg_tty_probe(struct rpmsg_device *rpdev) ...@@ -164,9 +162,8 @@ static int rpmsg_tty_probe(struct rpmsg_device *rpdev)
tty_dev = tty_port_register_device(&cport->port, rpmsg_tty_driver, tty_dev = tty_port_register_device(&cport->port, rpmsg_tty_driver,
cport->id, dev); cport->id, dev);
if (IS_ERR(tty_dev)) { if (IS_ERR(tty_dev)) {
dev_err(dev, "Failed to register tty port\n"); ret = dev_err_probe(dev, PTR_ERR(tty_dev), "Failed to register tty port\n");
ret = PTR_ERR(tty_dev); goto err_destroy;
goto err_destroy;
} }
cport->rpdev = rpdev; cport->rpdev = rpdev;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册