提交 85b722d7 编写于 作者: R Rickard Strandqvist 提交者: David S. Miller

isdn: hisax: l3ni1.c: Fix for possible null pointer dereference

There is otherwise a risk of a possible null pointer dereference.

Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: NRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
上级 29322d0d
...@@ -2059,13 +2059,17 @@ static int l3ni1_cmd_global(struct PStack *st, isdn_ctrl *ic) ...@@ -2059,13 +2059,17 @@ static int l3ni1_cmd_global(struct PStack *st, isdn_ctrl *ic)
memcpy(p, ic->parm.ni1_io.data, ic->parm.ni1_io.datalen); /* copy data */ memcpy(p, ic->parm.ni1_io.data, ic->parm.ni1_io.datalen); /* copy data */
l = (p - temp) + ic->parm.ni1_io.datalen; /* total length */ l = (p - temp) + ic->parm.ni1_io.datalen; /* total length */
if (ic->parm.ni1_io.timeout > 0) if (ic->parm.ni1_io.timeout > 0) {
if (!(pc = ni1_new_l3_process(st, -1))) pc = ni1_new_l3_process(st, -1);
{ free_invoke_id(st, id); if (!pc) {
free_invoke_id(st, id);
return (-2); return (-2);
} }
pc->prot.ni1.ll_id = ic->parm.ni1_io.ll_id; /* remember id */ /* remember id */
pc->prot.ni1.proc = ic->parm.ni1_io.proc; /* and procedure */ pc->prot.ni1.ll_id = ic->parm.ni1_io.ll_id;
/* and procedure */
pc->prot.ni1.proc = ic->parm.ni1_io.proc;
}
if (!(skb = l3_alloc_skb(l))) if (!(skb = l3_alloc_skb(l)))
{ free_invoke_id(st, id); { free_invoke_id(st, id);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册