提交 8223ecc4 编写于 作者: C Chao Yu 提交者: Jaegeuk Kim

f2fs: fix to add missing F2FS_IO_ALIGNED() condition

In f2fs_allocate_data_block(), we will reset fio.retry for IO
alignment feature instead of IO serialization feature.

In addition, spread F2FS_IO_ALIGNED() to check IO alignment
feature status explicitly.
Signed-off-by: NChao Yu <yuchao0@huawei.com>
Signed-off-by: NJaegeuk Kim <jaegeuk@kernel.org>
上级 9720ee80
...@@ -294,6 +294,9 @@ static inline void __submit_bio(struct f2fs_sb_info *sbi, ...@@ -294,6 +294,9 @@ static inline void __submit_bio(struct f2fs_sb_info *sbi,
if (test_opt(sbi, LFS) && current->plug) if (test_opt(sbi, LFS) && current->plug)
blk_finish_plug(current->plug); blk_finish_plug(current->plug);
if (F2FS_IO_ALIGNED(sbi))
goto submit_io;
start = bio->bi_iter.bi_size >> F2FS_BLKSIZE_BITS; start = bio->bi_iter.bi_size >> F2FS_BLKSIZE_BITS;
start %= F2FS_IO_SIZE(sbi); start %= F2FS_IO_SIZE(sbi);
...@@ -607,7 +610,8 @@ void f2fs_submit_page_write(struct f2fs_io_info *fio) ...@@ -607,7 +610,8 @@ void f2fs_submit_page_write(struct f2fs_io_info *fio)
__submit_merged_bio(io); __submit_merged_bio(io);
alloc_new: alloc_new:
if (io->bio == NULL) { if (io->bio == NULL) {
if ((fio->type == DATA || fio->type == NODE) && if (F2FS_IO_ALIGNED(sbi) &&
(fio->type == DATA || fio->type == NODE) &&
fio->new_blkaddr & F2FS_IO_SIZE_MASK(sbi)) { fio->new_blkaddr & F2FS_IO_SIZE_MASK(sbi)) {
dec_page_count(sbi, WB_DATA_TYPE(bio_page)); dec_page_count(sbi, WB_DATA_TYPE(bio_page));
fio->retry = true; fio->retry = true;
......
...@@ -3116,12 +3116,14 @@ void f2fs_allocate_data_block(struct f2fs_sb_info *sbi, struct page *page, ...@@ -3116,12 +3116,14 @@ void f2fs_allocate_data_block(struct f2fs_sb_info *sbi, struct page *page,
f2fs_inode_chksum_set(sbi, page); f2fs_inode_chksum_set(sbi, page);
} }
if (F2FS_IO_ALIGNED(sbi))
fio->retry = false;
if (add_list) { if (add_list) {
struct f2fs_bio_info *io; struct f2fs_bio_info *io;
INIT_LIST_HEAD(&fio->list); INIT_LIST_HEAD(&fio->list);
fio->in_list = true; fio->in_list = true;
fio->retry = false;
io = sbi->write_io[fio->type] + fio->temp; io = sbi->write_io[fio->type] + fio->temp;
spin_lock(&io->io_lock); spin_lock(&io->io_lock);
list_add_tail(&fio->list, &io->io_list); list_add_tail(&fio->list, &io->io_list);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册