提交 8181e8a7 编写于 作者: M Ming Lei 提交者: Jinjiang Tu

zram: fix race between zram_reset_device() and disksize_store()

mainline inclusion
from mainline-v5.16-rc1
commit 6f163779
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I7TWVA
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=6f1637795f2827d36aec9e0246487f5852e8abf7

-------------------------------------------

When the ->init_lock is released in zram_reset_device(), disksize_store()
can come in and try to allocate meta, but zram_reset_device() is freeing
free meta, so cause races.

Link: https://lore.kernel.org/linux-block/20210927163805.808907-1-mcgrof@kernel.org/T/#mc617f865a3fa2778e40f317ddf48f6447c20c073Reported-by: NLuis Chamberlain <mcgrof@kernel.org>
Reviewed-by: NLuis Chamberlain <mcgrof@kernel.org>
Signed-off-by: NMing Lei <ming.lei@redhat.com>
Acked-by: NMinchan Kim <minchan@kernel.org>
Link: https://lore.kernel.org/r/20211025025426.2815424-2-ming.lei@redhat.comSigned-off-by: NJens Axboe <axboe@kernel.dk>
Signed-off-by: NJinjiang Tu <tujinjiang@huawei.com>
上级 de22a0cb
...@@ -1703,12 +1703,13 @@ static void zram_reset_device(struct zram *zram) ...@@ -1703,12 +1703,13 @@ static void zram_reset_device(struct zram *zram)
set_capacity(zram->disk, 0); set_capacity(zram->disk, 0);
part_stat_set_all(&zram->disk->part0, 0); part_stat_set_all(&zram->disk->part0, 0);
up_write(&zram->init_lock);
/* I/O operation under all of CPU are done so let's free */ /* I/O operation under all of CPU are done so let's free */
zram_meta_free(zram, disksize); zram_meta_free(zram, disksize);
memset(&zram->stats, 0, sizeof(zram->stats)); memset(&zram->stats, 0, sizeof(zram->stats));
zcomp_destroy(comp); zcomp_destroy(comp);
reset_bdev(zram); reset_bdev(zram);
up_write(&zram->init_lock);
} }
static ssize_t disksize_store(struct device *dev, static ssize_t disksize_store(struct device *dev,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册