提交 805a6ef8 编写于 作者: K Krzysztof Kozlowski 提交者: Bartosz Golaszewski

gpio: zynq: Simplify with dev_err_probe()

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.
Signed-off-by: NKrzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: NBartosz Golaszewski <bgolaszewski@baylibre.com>
上级 308a028d
...@@ -929,11 +929,9 @@ static int zynq_gpio_probe(struct platform_device *pdev) ...@@ -929,11 +929,9 @@ static int zynq_gpio_probe(struct platform_device *pdev)
/* Retrieve GPIO clock */ /* Retrieve GPIO clock */
gpio->clk = devm_clk_get(&pdev->dev, NULL); gpio->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(gpio->clk)) { if (IS_ERR(gpio->clk))
if (PTR_ERR(gpio->clk) != -EPROBE_DEFER) return dev_err_probe(&pdev->dev, PTR_ERR(gpio->clk), "input clock not found.\n");
dev_err(&pdev->dev, "input clock not found.\n");
return PTR_ERR(gpio->clk);
}
ret = clk_prepare_enable(gpio->clk); ret = clk_prepare_enable(gpio->clk);
if (ret) { if (ret) {
dev_err(&pdev->dev, "Unable to enable clock.\n"); dev_err(&pdev->dev, "Unable to enable clock.\n");
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册