提交 7d90e86d 编写于 作者: P Patrick McHardy 提交者: David S. Miller

[NETFILTER]: nfnetlink_log: fix module reference counting

Count module references correctly: after instance_destroy() there
might be timer pending and holding a reference for this netlink instance.

Based on patch by Michal Miroslaw <mirq-linux@rere.qmqm.pl>
Signed-off-by: NPatrick McHardy <kaber@trash.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 dd16704e
...@@ -133,6 +133,7 @@ instance_put(struct nfulnl_instance *inst) ...@@ -133,6 +133,7 @@ instance_put(struct nfulnl_instance *inst)
if (inst && atomic_dec_and_test(&inst->use)) { if (inst && atomic_dec_and_test(&inst->use)) {
UDEBUG("kfree(inst=%p)\n", inst); UDEBUG("kfree(inst=%p)\n", inst);
kfree(inst); kfree(inst);
module_put(THIS_MODULE);
} }
} }
...@@ -228,8 +229,6 @@ _instance_destroy2(struct nfulnl_instance *inst, int lock) ...@@ -228,8 +229,6 @@ _instance_destroy2(struct nfulnl_instance *inst, int lock)
/* and finally put the refcount */ /* and finally put the refcount */
instance_put(inst); instance_put(inst);
module_put(THIS_MODULE);
} }
static inline void static inline void
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册