提交 76af8cbb 编写于 作者: S Shixin Liu 提交者: Zheng Zengkai

crypto: sun8i-ss - Fix PM reference leak when pm_runtime_get_sync() fails

stable inclusion
from stable-5.10.36
commit 2264965f576ff434ee7121edc98a83b072d4e645
bugzilla: 51867
CVE: NA

--------------------------------

[ Upstream commit 06cd7423 ]

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Signed-off-by: NShixin Liu <liushixin2@huawei.com>
Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: NSasha Levin <sashal@kernel.org>
Signed-off-by: NChen Jun <chenjun102@huawei.com>
Acked-by: NWeilong Chen <chenweilong@huawei.com>
Signed-off-by: NZheng Zengkai <zhengzengkai@huawei.com>
上级 e44c11c7
...@@ -351,7 +351,7 @@ int sun8i_ss_cipher_init(struct crypto_tfm *tfm) ...@@ -351,7 +351,7 @@ int sun8i_ss_cipher_init(struct crypto_tfm *tfm)
op->enginectx.op.prepare_request = NULL; op->enginectx.op.prepare_request = NULL;
op->enginectx.op.unprepare_request = NULL; op->enginectx.op.unprepare_request = NULL;
err = pm_runtime_get_sync(op->ss->dev); err = pm_runtime_resume_and_get(op->ss->dev);
if (err < 0) { if (err < 0) {
dev_err(op->ss->dev, "pm error %d\n", err); dev_err(op->ss->dev, "pm error %d\n", err);
goto error_pm; goto error_pm;
......
...@@ -753,7 +753,7 @@ static int sun8i_ss_probe(struct platform_device *pdev) ...@@ -753,7 +753,7 @@ static int sun8i_ss_probe(struct platform_device *pdev)
if (err) if (err)
goto error_alg; goto error_alg;
err = pm_runtime_get_sync(ss->dev); err = pm_runtime_resume_and_get(ss->dev);
if (err < 0) if (err < 0)
goto error_alg; goto error_alg;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册