提交 71dc525c 编写于 作者: J Julien Brunel 提交者: Jaroslav Kysela

ALSA: sound/soc/at32: Useless NULL test

The test (ssc != NULL) can only be reached if the call to the function
ssc_request, the result of which ssc is assigned, succeeds. Moreover,
two statements assign NULL to ssc just before a return, which is useless
since it is a local variable. So, we suggest to delete the test and
the two assignments.

A simplified version of the semantic match that finds this problem is
as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@bad_null_test@
expression x,E;
@@
x = ssc_request(...)
... when != x = E
* x != NULL
// </smpl>
Signed-off-by: NJulien Brunel <brunel@diku.dk>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Acked-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
Signed-off-by: NJaroslav Kysela <perex@perex.cz>
上级 9a9e2359
...@@ -406,7 +406,6 @@ static int __init playpaq_asoc_init(void) ...@@ -406,7 +406,6 @@ static int __init playpaq_asoc_init(void)
ssc = ssc_request(0); ssc = ssc_request(0);
if (IS_ERR(ssc)) { if (IS_ERR(ssc)) {
ret = PTR_ERR(ssc); ret = PTR_ERR(ssc);
ssc = NULL;
goto err_ssc; goto err_ssc;
} }
ssc_p->ssc = ssc; ssc_p->ssc = ssc;
...@@ -477,10 +476,7 @@ static int __init playpaq_asoc_init(void) ...@@ -477,10 +476,7 @@ static int __init playpaq_asoc_init(void)
_gclk0 = NULL; _gclk0 = NULL;
} }
err_gclk0: err_gclk0:
if (ssc != NULL) { ssc_free(ssc);
ssc_free(ssc);
ssc = NULL;
}
err_ssc: err_ssc:
return ret; return ret;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册