提交 6ec1b71f 编写于 作者: J Jacob Keller 提交者: Jeff Kirsher

ixgbe: fix several concatenated strings to single line

This patch fixes various log strings that are split over multiple lines
in the ixgbe driver. This cleans up checkpatch.pl warnings, and makes it
easier to search the code for warning strings displayed to the kernel
log.
Signed-off-by: NJacob Keller <jacob.e.keller@intel.com>
Tested-by: NPhil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>
上级 2b2005d2
...@@ -1285,8 +1285,7 @@ s32 ixgbe_reinit_fdir_tables_82599(struct ixgbe_hw *hw) ...@@ -1285,8 +1285,7 @@ s32 ixgbe_reinit_fdir_tables_82599(struct ixgbe_hw *hw)
udelay(10); udelay(10);
} }
if (i >= IXGBE_FDIRCMD_CMD_POLL) { if (i >= IXGBE_FDIRCMD_CMD_POLL) {
hw_dbg(hw, "Flow Director previous command isn't complete, " hw_dbg(hw, "Flow Director previous command isn't complete, aborting table re-initialization.\n");
"aborting table re-initialization.\n");
return IXGBE_ERR_FDIR_REINIT_FAILED; return IXGBE_ERR_FDIR_REINIT_FAILED;
} }
......
...@@ -818,9 +818,8 @@ s32 ixgbe_init_eeprom_params_generic(struct ixgbe_hw *hw) ...@@ -818,9 +818,8 @@ s32 ixgbe_init_eeprom_params_generic(struct ixgbe_hw *hw)
eeprom->address_bits = 16; eeprom->address_bits = 16;
else else
eeprom->address_bits = 8; eeprom->address_bits = 8;
hw_dbg(hw, "Eeprom params: type = %d, size = %d, address bits: " hw_dbg(hw, "Eeprom params: type = %d, size = %d, address bits: %d\n",
"%d\n", eeprom->type, eeprom->word_size, eeprom->type, eeprom->word_size, eeprom->address_bits);
eeprom->address_bits);
} }
return 0; return 0;
...@@ -1392,8 +1391,7 @@ static s32 ixgbe_get_eeprom_semaphore(struct ixgbe_hw *hw) ...@@ -1392,8 +1391,7 @@ static s32 ixgbe_get_eeprom_semaphore(struct ixgbe_hw *hw)
} }
if (i == timeout) { if (i == timeout) {
hw_dbg(hw, "Driver can't access the Eeprom - SMBI Semaphore " hw_dbg(hw, "Driver can't access the Eeprom - SMBI Semaphore not granted.\n");
"not granted.\n");
/* /*
* this release is particularly important because our attempts * this release is particularly important because our attempts
* above to get the semaphore may have succeeded, and if there * above to get the semaphore may have succeeded, and if there
...@@ -1438,14 +1436,12 @@ static s32 ixgbe_get_eeprom_semaphore(struct ixgbe_hw *hw) ...@@ -1438,14 +1436,12 @@ static s32 ixgbe_get_eeprom_semaphore(struct ixgbe_hw *hw)
* was not granted because we don't have access to the EEPROM * was not granted because we don't have access to the EEPROM
*/ */
if (i >= timeout) { if (i >= timeout) {
hw_dbg(hw, "SWESMBI Software EEPROM semaphore " hw_dbg(hw, "SWESMBI Software EEPROM semaphore not granted.\n");
"not granted.\n");
ixgbe_release_eeprom_semaphore(hw); ixgbe_release_eeprom_semaphore(hw);
status = IXGBE_ERR_EEPROM; status = IXGBE_ERR_EEPROM;
} }
} else { } else {
hw_dbg(hw, "Software semaphore SMBI between device drivers " hw_dbg(hw, "Software semaphore SMBI between device drivers not granted.\n");
"not granted.\n");
} }
return status; return status;
...@@ -2663,8 +2659,7 @@ s32 ixgbe_disable_rx_buff_generic(struct ixgbe_hw *hw) ...@@ -2663,8 +2659,7 @@ s32 ixgbe_disable_rx_buff_generic(struct ixgbe_hw *hw)
/* For informational purposes only */ /* For informational purposes only */
if (i >= IXGBE_MAX_SECRX_POLL) if (i >= IXGBE_MAX_SECRX_POLL)
hw_dbg(hw, "Rx unit being enabled before security " hw_dbg(hw, "Rx unit being enabled before security path fully disabled. Continuing with init.\n");
"path fully disabled. Continuing with init.\n");
return 0; return 0;
......
...@@ -1357,8 +1357,7 @@ static bool reg_pattern_test(struct ixgbe_adapter *adapter, u64 *data, int reg, ...@@ -1357,8 +1357,7 @@ static bool reg_pattern_test(struct ixgbe_adapter *adapter, u64 *data, int reg,
ixgbe_write_reg(&adapter->hw, reg, test_pattern[pat] & write); ixgbe_write_reg(&adapter->hw, reg, test_pattern[pat] & write);
val = ixgbe_read_reg(&adapter->hw, reg); val = ixgbe_read_reg(&adapter->hw, reg);
if (val != (test_pattern[pat] & write & mask)) { if (val != (test_pattern[pat] & write & mask)) {
e_err(drv, "pattern test reg %04X failed: got " e_err(drv, "pattern test reg %04X failed: got 0x%08X expected 0x%08X\n",
"0x%08X expected 0x%08X\n",
reg, val, (test_pattern[pat] & write & mask)); reg, val, (test_pattern[pat] & write & mask));
*data = reg; *data = reg;
ixgbe_write_reg(&adapter->hw, reg, before); ixgbe_write_reg(&adapter->hw, reg, before);
...@@ -1382,8 +1381,8 @@ static bool reg_set_and_check(struct ixgbe_adapter *adapter, u64 *data, int reg, ...@@ -1382,8 +1381,8 @@ static bool reg_set_and_check(struct ixgbe_adapter *adapter, u64 *data, int reg,
ixgbe_write_reg(&adapter->hw, reg, write & mask); ixgbe_write_reg(&adapter->hw, reg, write & mask);
val = ixgbe_read_reg(&adapter->hw, reg); val = ixgbe_read_reg(&adapter->hw, reg);
if ((write & mask) != (val & mask)) { if ((write & mask) != (val & mask)) {
e_err(drv, "set/check reg %04X test failed: got 0x%08X " e_err(drv, "set/check reg %04X test failed: got 0x%08X expected 0x%08X\n",
"expected 0x%08X\n", reg, (val & mask), (write & mask)); reg, (val & mask), (write & mask));
*data = reg; *data = reg;
ixgbe_write_reg(&adapter->hw, reg, before); ixgbe_write_reg(&adapter->hw, reg, before);
return true; return true;
...@@ -1430,8 +1429,8 @@ static int ixgbe_reg_test(struct ixgbe_adapter *adapter, u64 *data) ...@@ -1430,8 +1429,8 @@ static int ixgbe_reg_test(struct ixgbe_adapter *adapter, u64 *data)
ixgbe_write_reg(&adapter->hw, IXGBE_STATUS, toggle); ixgbe_write_reg(&adapter->hw, IXGBE_STATUS, toggle);
after = ixgbe_read_reg(&adapter->hw, IXGBE_STATUS) & toggle; after = ixgbe_read_reg(&adapter->hw, IXGBE_STATUS) & toggle;
if (value != after) { if (value != after) {
e_err(drv, "failed STATUS register test got: 0x%08X " e_err(drv, "failed STATUS register test got: 0x%08X expected: 0x%08X\n",
"expected: 0x%08X\n", after, value); after, value);
*data = 1; *data = 1;
return 1; return 1;
} }
...@@ -1987,10 +1986,7 @@ static void ixgbe_diag_test(struct net_device *netdev, ...@@ -1987,10 +1986,7 @@ static void ixgbe_diag_test(struct net_device *netdev,
int i; int i;
for (i = 0; i < adapter->num_vfs; i++) { for (i = 0; i < adapter->num_vfs; i++) {
if (adapter->vfinfo[i].clear_to_send) { if (adapter->vfinfo[i].clear_to_send) {
netdev_warn(netdev, "%s", netdev_warn(netdev, "offline diagnostic is not supported when VFs are present\n");
"offline diagnostic is not "
"supported when VFs are "
"present\n");
data[0] = 1; data[0] = 1;
data[1] = 1; data[1] = 1;
data[2] = 1; data[2] = 1;
...@@ -2037,8 +2033,7 @@ static void ixgbe_diag_test(struct net_device *netdev, ...@@ -2037,8 +2033,7 @@ static void ixgbe_diag_test(struct net_device *netdev,
* loopback diagnostic. */ * loopback diagnostic. */
if (adapter->flags & (IXGBE_FLAG_SRIOV_ENABLED | if (adapter->flags & (IXGBE_FLAG_SRIOV_ENABLED |
IXGBE_FLAG_VMDQ_ENABLED)) { IXGBE_FLAG_VMDQ_ENABLED)) {
e_info(hw, "Skip MAC loopback diagnostic in VT " e_info(hw, "Skip MAC loopback diagnostic in VT mode\n");
"mode\n");
data[3] = 0; data[3] = 0;
goto skip_loopback; goto skip_loopback;
} }
...@@ -2222,8 +2217,7 @@ static bool ixgbe_update_rsc(struct ixgbe_adapter *adapter) ...@@ -2222,8 +2217,7 @@ static bool ixgbe_update_rsc(struct ixgbe_adapter *adapter)
adapter->rx_itr_setting > IXGBE_MIN_RSC_ITR) { adapter->rx_itr_setting > IXGBE_MIN_RSC_ITR) {
if (!(adapter->flags2 & IXGBE_FLAG2_RSC_ENABLED)) { if (!(adapter->flags2 & IXGBE_FLAG2_RSC_ENABLED)) {
adapter->flags2 |= IXGBE_FLAG2_RSC_ENABLED; adapter->flags2 |= IXGBE_FLAG2_RSC_ENABLED;
e_info(probe, "rx-usecs value high enough " e_info(probe, "rx-usecs value high enough to re-enable RSC\n");
"to re-enable RSC\n");
return true; return true;
} }
/* if interrupt rate is too high then disable RSC */ /* if interrupt rate is too high then disable RSC */
...@@ -2787,8 +2781,7 @@ static int ixgbe_set_rss_hash_opt(struct ixgbe_adapter *adapter, ...@@ -2787,8 +2781,7 @@ static int ixgbe_set_rss_hash_opt(struct ixgbe_adapter *adapter,
if ((flags2 & UDP_RSS_FLAGS) && if ((flags2 & UDP_RSS_FLAGS) &&
!(adapter->flags2 & UDP_RSS_FLAGS)) !(adapter->flags2 & UDP_RSS_FLAGS))
e_warn(drv, "enabling UDP RSS: fragmented packets" e_warn(drv, "enabling UDP RSS: fragmented packets may arrive out of order to the stack above\n");
" may arrive out of order to the stack above\n");
adapter->flags2 = flags2; adapter->flags2 = flags2;
......
...@@ -1113,8 +1113,8 @@ static void ixgbe_set_interrupt_capability(struct ixgbe_adapter *adapter) ...@@ -1113,8 +1113,8 @@ static void ixgbe_set_interrupt_capability(struct ixgbe_adapter *adapter)
err = pci_enable_msi(adapter->pdev); err = pci_enable_msi(adapter->pdev);
if (err) { if (err) {
netif_printk(adapter, hw, KERN_DEBUG, adapter->netdev, netif_printk(adapter, hw, KERN_DEBUG, adapter->netdev,
"Unable to allocate MSI interrupt, " "Unable to allocate MSI interrupt, falling back to legacy. Error: %d\n",
"falling back to legacy. Error: %d\n", err); err);
return; return;
} }
adapter->flags |= IXGBE_FLAG_MSI_ENABLED; adapter->flags |= IXGBE_FLAG_MSI_ENABLED;
......
...@@ -712,8 +712,7 @@ static s32 ixgbe_get_swfw_sync_semaphore(struct ixgbe_hw *hw) ...@@ -712,8 +712,7 @@ static s32 ixgbe_get_swfw_sync_semaphore(struct ixgbe_hw *hw)
udelay(50); udelay(50);
} }
} else { } else {
hw_dbg(hw, "Software semaphore SMBI between device drivers " hw_dbg(hw, "Software semaphore SMBI between device drivers not granted.\n");
"not granted.\n");
} }
return status; return status;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册