提交 6a4c6645 编写于 作者: H Hans Verkuil 提交者: Mauro Carvalho Chehab

media: i2c: ov7670: 0 instead of -EINVAL was returned

If the media bus is unsupported, then return -EINVAL. Instead it
returned 'ret' which happened to be 0.

This fixes a smatch warning:

ov7670.c:1843 ov7670_parse_dt() warn: missing error code? 'ret'
Signed-off-by: NHans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: 01b84448 ("media: v4l2: i2c: ov7670: Implement OF mbus configuration")
Acked-by: NSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@kernel.org>
上级 0d3732fb
...@@ -1840,7 +1840,7 @@ static int ov7670_parse_dt(struct device *dev, ...@@ -1840,7 +1840,7 @@ static int ov7670_parse_dt(struct device *dev,
if (bus_cfg.bus_type != V4L2_MBUS_PARALLEL) { if (bus_cfg.bus_type != V4L2_MBUS_PARALLEL) {
dev_err(dev, "Unsupported media bus type\n"); dev_err(dev, "Unsupported media bus type\n");
return ret; return -EINVAL;
} }
info->mbus_config = bus_cfg.bus.parallel.flags; info->mbus_config = bus_cfg.bus.parallel.flags;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册