提交 67bbbcb4 编写于 作者: D Dan Carpenter 提交者: Linus Walleij

pinctrl: mediatek: uninitialized variable in mtk_pctrl_show_one_pin()

The "try_all_type" variable is not set if (hw->soc->pull_type) is false
leading to the following Smatch warning:

    drivers/pinctrl/mediatek/pinctrl-paris.c:599 mtk_pctrl_show_one_pin()
    error: uninitialized symbol 'try_all_type'.

Fixes: fb34a9ae ("pinctrl: mediatek: support rsel feature")
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211127140750.GA24002@kiliSigned-off-by: NLinus Walleij <linus.walleij@linaro.org>
上级 debc8b0b
......@@ -581,7 +581,7 @@ ssize_t mtk_pctrl_show_one_pin(struct mtk_pinctrl *hw,
{
int pinmux, pullup, pullen, len = 0, r1 = -1, r0 = -1, rsel = -1;
const struct mtk_pin_desc *desc;
u32 try_all_type;
u32 try_all_type = 0;
if (gpio >= hw->soc->npins)
return -EINVAL;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册