提交 64a68158 编写于 作者: H Harshit Mogalapalli 提交者: Jonathan Cameron

iio: accel: mma9551_core: Prevent uninitialized variable in mma9551_read_config_word()

Smatch Warns:
drivers/iio/accel/mma9551_core.c:299
	mma9551_read_config_word() error: uninitialized symbol 'v'.

When (offset >= 1 << 12) is true mma9551_transfer() will return -EINVAL
without 'v' being initialized, so check for the error and return.

Note: No actual bug as caller checks the return value and does not
use the parameter in the problem case.
Signed-off-by: NHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20230126153610.3586243-1-harshit.m.mogalapalli@oracle.comSigned-off-by: NJonathan Cameron <Jonathan.Cameron@huawei.com>
上级 e56d2c34
...@@ -296,9 +296,12 @@ int mma9551_read_config_word(struct i2c_client *client, u8 app_id, ...@@ -296,9 +296,12 @@ int mma9551_read_config_word(struct i2c_client *client, u8 app_id,
ret = mma9551_transfer(client, app_id, MMA9551_CMD_READ_CONFIG, ret = mma9551_transfer(client, app_id, MMA9551_CMD_READ_CONFIG,
reg, NULL, 0, (u8 *)&v, 2); reg, NULL, 0, (u8 *)&v, 2);
if (ret < 0)
return ret;
*val = be16_to_cpu(v); *val = be16_to_cpu(v);
return ret; return 0;
} }
EXPORT_SYMBOL_NS(mma9551_read_config_word, IIO_MMA9551); EXPORT_SYMBOL_NS(mma9551_read_config_word, IIO_MMA9551);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册