提交 63149a11 编写于 作者: N Navid Emamdoost 提交者: Yang Yingliang

nbd_genl_status: null check for nla_nest_start

hulk inclusion
category: bugfix
bugzilla: NA
CVE: CVE-2019-16089

---------------------------

nla_nest_start may fail and return NULL. The check is inserted, and
errno is selected based on other call sites within the same source code.
Update: removed extra new line.
v3 Update: added release reply, thanks to Michal Kubecek for pointing
out.
Signed-off-by: NNavid Emamdoost <navid.emamdoost@gmail.com>
Reviewed-by: NMichal Kubecek <mkubecek@suse.cz>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: NJason Yan <yanaijie@huawei.com>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
上级 b3340087
...@@ -2169,6 +2169,12 @@ static int nbd_genl_status(struct sk_buff *skb, struct genl_info *info) ...@@ -2169,6 +2169,12 @@ static int nbd_genl_status(struct sk_buff *skb, struct genl_info *info)
} }
dev_list = nla_nest_start(reply, NBD_ATTR_DEVICE_LIST); dev_list = nla_nest_start(reply, NBD_ATTR_DEVICE_LIST);
if (!dev_list) {
nlmsg_free(reply);
ret = -EMSGSIZE;
goto out;
}
if (index == -1) { if (index == -1) {
ret = idr_for_each(&nbd_index_idr, &status_cb, reply); ret = idr_for_each(&nbd_index_idr, &status_cb, reply);
if (ret) { if (ret) {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册