提交 581733e6 编写于 作者: P Peter Rosin 提交者: Wolfram Sang

media: tda18271: switch to i2c_lock_bus(..., I2C_LOCK_SEGMENT)

Locking the root adapter for __i2c_transfer will deadlock if the
device sits behind a mux-locked I2C mux. Switch to the finer-grained
i2c_lock_bus with the I2C_LOCK_SEGMENT flag. If the device does not
sit behind a mux-locked mux, the two locking variants are equivalent.
Signed-off-by: NPeter Rosin <peda@axentia.se>
Acked-by: NMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: NWolfram Sang <wsa@the-dreams.de>
上级 3e985b3d
...@@ -225,7 +225,7 @@ static int __tda18271_write_regs(struct dvb_frontend *fe, int idx, int len, ...@@ -225,7 +225,7 @@ static int __tda18271_write_regs(struct dvb_frontend *fe, int idx, int len,
*/ */
if (lock_i2c) { if (lock_i2c) {
tda18271_i2c_gate_ctrl(fe, 1); tda18271_i2c_gate_ctrl(fe, 1);
i2c_lock_adapter(priv->i2c_props.adap); i2c_lock_bus(priv->i2c_props.adap, I2C_LOCK_SEGMENT);
} }
while (len) { while (len) {
if (max > len) if (max > len)
...@@ -246,7 +246,7 @@ static int __tda18271_write_regs(struct dvb_frontend *fe, int idx, int len, ...@@ -246,7 +246,7 @@ static int __tda18271_write_regs(struct dvb_frontend *fe, int idx, int len,
len -= max; len -= max;
} }
if (lock_i2c) { if (lock_i2c) {
i2c_unlock_adapter(priv->i2c_props.adap); i2c_unlock_bus(priv->i2c_props.adap, I2C_LOCK_SEGMENT);
tda18271_i2c_gate_ctrl(fe, 0); tda18271_i2c_gate_ctrl(fe, 0);
} }
...@@ -300,7 +300,7 @@ int tda18271_init_regs(struct dvb_frontend *fe) ...@@ -300,7 +300,7 @@ int tda18271_init_regs(struct dvb_frontend *fe)
* as those could cause bad things * as those could cause bad things
*/ */
tda18271_i2c_gate_ctrl(fe, 1); tda18271_i2c_gate_ctrl(fe, 1);
i2c_lock_adapter(priv->i2c_props.adap); i2c_lock_bus(priv->i2c_props.adap, I2C_LOCK_SEGMENT);
/* initialize registers */ /* initialize registers */
switch (priv->id) { switch (priv->id) {
...@@ -516,7 +516,7 @@ int tda18271_init_regs(struct dvb_frontend *fe) ...@@ -516,7 +516,7 @@ int tda18271_init_regs(struct dvb_frontend *fe)
/* synchronize */ /* synchronize */
__tda18271_write_regs(fe, R_EP1, 1, false); __tda18271_write_regs(fe, R_EP1, 1, false);
i2c_unlock_adapter(priv->i2c_props.adap); i2c_unlock_bus(priv->i2c_props.adap, I2C_LOCK_SEGMENT);
tda18271_i2c_gate_ctrl(fe, 0); tda18271_i2c_gate_ctrl(fe, 0);
return 0; return 0;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册