提交 51b3e270 编写于 作者: A Andrew Klossner 提交者: Jean Delvare

hwmon: (f75375s) Remove unnecessary and confusing initialization

f75375_probe calls i2c_get_clientdata to initialize the data pointer,
but there isn't yet any client data to get, and the value is never
used before the variable is assigned a new value seven lines later.

The call doesn't hurt anything and wastes only a couple of cycles.
The reason to fix it is because this module serves as an example to
hackers writing new hwmon drivers, and this part of the example is
confusing.
Signed-off-by: NAndrew Klossner <andrew@cesa.opbu.xerox.com>
Signed-off-by: NJean Delvare <khali@linux-fr.org>
上级 e267d250
...@@ -617,7 +617,7 @@ static void f75375_init(struct i2c_client *client, struct f75375_data *data, ...@@ -617,7 +617,7 @@ static void f75375_init(struct i2c_client *client, struct f75375_data *data,
static int f75375_probe(struct i2c_client *client, static int f75375_probe(struct i2c_client *client,
const struct i2c_device_id *id) const struct i2c_device_id *id)
{ {
struct f75375_data *data = i2c_get_clientdata(client); struct f75375_data *data;
struct f75375s_platform_data *f75375s_pdata = client->dev.platform_data; struct f75375s_platform_data *f75375s_pdata = client->dev.platform_data;
int err; int err;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册