You need to sign in or sign up before continuing.
提交 4dae9dd1 编写于 作者: Y Yicong Yang 提交者: Zheng Zengkai

spi: hisi-sfc-v3xx: extend version checking compatibility

mainline inclusion
from mainline-v5.12-rc1
commit 566c6120
category: feature
bugzilla: https://gitee.com/openeuler/kernel/issues/I5QUS6
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=566c6120f095

--------------------------------------------------------------------------

Currently we use concrete version to determine the max_cmd_dword.
New entries should be added for compatible hardwares of new version
or on new platform, otherwise the device will use 16 dwords instead
of 64 even if it supports, which will degrade the performance.
This will decrease the compatibility and the maintainability.

Drop the switch-case statement of the version checking. Only version
less than 0x351 supports maximum 16 command dwords.
Signed-off-by: NYicong Yang <yangyicong@hisilicon.com>
Acked-by: NJohn Garry <john.garry@huawei.com>
Link: https://lore.kernel.org/r/1610526716-14882-1-git-send-email-yangyicong@hisilicon.comSigned-off-by: NMark Brown <broonie@kernel.org>
Signed-off-by: NWangming Shao <shaowangming@h-partners.com>
Reviewed-by: NYicong Yang <yangyicong@huawei.com>
Acked-by: NXie XiuQi <xiexiuqi@huawei.com>
Signed-off-by: NZheng Zengkai <zhengzengkai@huawei.com>
上级 1d601bab
...@@ -465,14 +465,10 @@ static int hisi_sfc_v3xx_probe(struct platform_device *pdev) ...@@ -465,14 +465,10 @@ static int hisi_sfc_v3xx_probe(struct platform_device *pdev)
version = readl(host->regbase + HISI_SFC_V3XX_VERSION); version = readl(host->regbase + HISI_SFC_V3XX_VERSION);
switch (version) { if (version >= 0x351)
case 0x351:
host->max_cmd_dword = 64; host->max_cmd_dword = 64;
break; else
default:
host->max_cmd_dword = 16; host->max_cmd_dword = 16;
break;
}
ret = devm_spi_register_controller(dev, ctlr); ret = devm_spi_register_controller(dev, ctlr);
if (ret) if (ret)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册