提交 41196179 编写于 作者: A Axel Lin 提交者: Matthew Garrett

intel_pmic_gpio: fix off-by-one value range checking

In pmic_irq_type(), we use gpio as array index for trigger,
thus the valid value range for gpio should be 0 .. NUM_GPIO - 1.
Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Signed-off-by: NMatthew Garrett <mjg@redhat.com>
上级 35f0ce03
...@@ -197,7 +197,7 @@ static int pmic_irq_type(unsigned irq, unsigned type) ...@@ -197,7 +197,7 @@ static int pmic_irq_type(unsigned irq, unsigned type)
u32 gpio = irq - pg->irq_base; u32 gpio = irq - pg->irq_base;
unsigned long flags; unsigned long flags;
if (gpio > pg->chip.ngpio) if (gpio >= pg->chip.ngpio)
return -EINVAL; return -EINVAL;
spin_lock_irqsave(&pg->irqtypes.lock, flags); spin_lock_irqsave(&pg->irqtypes.lock, flags);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册