提交 3d45c86f 编写于 作者: H Heiner Kallweit 提交者: Ulf Hansson

mmc: meson-gx: minor improvements in meson_mmc_set_ios

val isn't used in the switch clause and afterwards there's an
identical statement. So remove it.

In case of an unexpected bus width the error message indicates
the intention to set the bus width to 4 and to go on.
So remove the return statement. This return statement also
conflicts with "setting to 4" because nothing would be set
actually before returning. 4bit bus width are chosen as
default as the vendor driver does it too.
Signed-off-by: NHeiner Kallweit <hkallweit1@gmail.com>
Acked-by: NKevin Hilman <khilman@baylibre.com>
Signed-off-by: NUlf Hansson <ulf.hansson@linaro.org>
上级 a4c38c8d
...@@ -371,7 +371,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) ...@@ -371,7 +371,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
meson_mmc_clk_set(host, ios->clock); meson_mmc_clk_set(host, ios->clock);
/* Bus width */ /* Bus width */
val = readl(host->regs + SD_EMMC_CFG);
switch (ios->bus_width) { switch (ios->bus_width) {
case MMC_BUS_WIDTH_1: case MMC_BUS_WIDTH_1:
bus_width = CFG_BUS_WIDTH_1; bus_width = CFG_BUS_WIDTH_1;
...@@ -386,7 +385,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) ...@@ -386,7 +385,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
dev_err(host->dev, "Invalid ios->bus_width: %u. Setting to 4.\n", dev_err(host->dev, "Invalid ios->bus_width: %u. Setting to 4.\n",
ios->bus_width); ios->bus_width);
bus_width = CFG_BUS_WIDTH_4; bus_width = CFG_BUS_WIDTH_4;
return;
} }
val = readl(host->regs + SD_EMMC_CFG); val = readl(host->regs + SD_EMMC_CFG);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册