提交 258c0563 编写于 作者: A Andre Bartke 提交者: Mauro Carvalho Chehab

[media] V4L: mx1-camera: fix uninitialized variable

mx1_camera_add_device() can return an uninitialized value of ret.
Signed-off-by: NAndre Bartke <andre.bartke@gmail.com>
[g.liakhovetski@gmx.de: modified the fix to remove "ret" completely]
Signed-off-by: NGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
上级 383e4f69
...@@ -444,12 +444,9 @@ static int mx1_camera_add_device(struct soc_camera_device *icd) ...@@ -444,12 +444,9 @@ static int mx1_camera_add_device(struct soc_camera_device *icd)
{ {
struct soc_camera_host *ici = to_soc_camera_host(icd->dev.parent); struct soc_camera_host *ici = to_soc_camera_host(icd->dev.parent);
struct mx1_camera_dev *pcdev = ici->priv; struct mx1_camera_dev *pcdev = ici->priv;
int ret;
if (pcdev->icd) { if (pcdev->icd)
ret = -EBUSY; return -EBUSY;
goto ebusy;
}
dev_info(icd->dev.parent, "MX1 Camera driver attached to camera %d\n", dev_info(icd->dev.parent, "MX1 Camera driver attached to camera %d\n",
icd->devnum); icd->devnum);
...@@ -458,8 +455,7 @@ static int mx1_camera_add_device(struct soc_camera_device *icd) ...@@ -458,8 +455,7 @@ static int mx1_camera_add_device(struct soc_camera_device *icd)
pcdev->icd = icd; pcdev->icd = icd;
ebusy: return 0;
return ret;
} }
static void mx1_camera_remove_device(struct soc_camera_device *icd) static void mx1_camera_remove_device(struct soc_camera_device *icd)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册