提交 232471a7 编写于 作者: X Xiongfeng Wang 提交者: sanglipeng

iommu/vt-d: Fix PCI device refcount leak in dmar_dev_scope_init()

stable inclusion
from stable-v5.10.158
commit a5c65cd56aed027f8a97fda8b691caaeb66d115e
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I7NTXH

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=a5c65cd56aed027f8a97fda8b691caaeb66d115e

--------------------------------

[ Upstream commit 4bedbbd7 ]

for_each_pci_dev() is implemented by pci_get_device(). The comment of
pci_get_device() says that it will increase the reference count for the
returned pci_dev and also decrease the reference count for the input
pci_dev @from if it is not NULL.

If we break for_each_pci_dev() loop with pdev not NULL, we need to call
pci_dev_put() to decrease the reference count. Add the missing
pci_dev_put() for the error path to avoid reference count leak.

Fixes: 2e455289 ("iommu/vt-d: Unify the way to process DMAR device scope array")
Signed-off-by: NXiongfeng Wang <wangxiongfeng2@huawei.com>
Link: https://lore.kernel.org/r/20221121113649.190393-3-wangxiongfeng2@huawei.comSigned-off-by: NLu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: NJoerg Roedel <jroedel@suse.de>
Signed-off-by: NSasha Levin <sashal@kernel.org>
Signed-off-by: Nsanglipeng <sanglipeng1@jd.com>
上级 150f5955
...@@ -827,6 +827,7 @@ int __init dmar_dev_scope_init(void) ...@@ -827,6 +827,7 @@ int __init dmar_dev_scope_init(void)
info = dmar_alloc_pci_notify_info(dev, info = dmar_alloc_pci_notify_info(dev,
BUS_NOTIFY_ADD_DEVICE); BUS_NOTIFY_ADD_DEVICE);
if (!info) { if (!info) {
pci_dev_put(dev);
return dmar_dev_scope_status; return dmar_dev_scope_status;
} else { } else {
dmar_pci_bus_add_dev(info); dmar_pci_bus_add_dev(info);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册