提交 21bb0ebf 编写于 作者: A Andrew Murray 提交者: Marc Zyngier

arm64: arm_pmu: Remove unnecessary isb instruction

The armv8pmu_enable_event_counter function issues an isb instruction
after enabling a pair of counters - this doesn't provide any value
and is inconsistent with the armv8pmu_disable_event_counter.

In any case armv8pmu_enable_event_counter is always called with the
PMU stopped. Starting the PMU with armv8pmu_start results in an isb
instruction being issued prior to writing to PMCR_EL0.

Let's remove the unnecessary isb instruction.
Signed-off-by: NAndrew Murray <andrew.murray@arm.com>
Reviewed-by: NSuzuki K Poulose <suzuki.poulose@arm.com>
Acked-by: NMark Rutland <mark.rutland@arm.com>
Signed-off-by: NMarc Zyngier <marc.zyngier@arm.com>
上级 a243c16d
...@@ -533,7 +533,6 @@ static inline void armv8pmu_enable_event_counter(struct perf_event *event) ...@@ -533,7 +533,6 @@ static inline void armv8pmu_enable_event_counter(struct perf_event *event)
armv8pmu_enable_counter(idx); armv8pmu_enable_counter(idx);
if (armv8pmu_event_is_chained(event)) if (armv8pmu_event_is_chained(event))
armv8pmu_enable_counter(idx - 1); armv8pmu_enable_counter(idx - 1);
isb();
} }
static inline int armv8pmu_disable_counter(int idx) static inline int armv8pmu_disable_counter(int idx)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册