提交 1c2c5eb6 编写于 作者: I Ido Schimmel 提交者: Jakub Kicinski

mlxsw: spectrum_router: Fix error handling issue

Return error to the caller instead of suppressing it.

Fixes: e3ddfb45 ("mlxsw: spectrum_router: Allow returning errors from mlxsw_sp_nexthop_group_refresh()")
Addresses-Coverity: ("Error handling issues  (CHECKED_RETURN)")
Signed-off-by: NIdo Schimmel <idosch@nvidia.com>
Signed-off-by: NJakub Kicinski <kuba@kernel.org>
上级 4be074e6
...@@ -3608,10 +3608,8 @@ mlxsw_sp_nexthop_group_refresh(struct mlxsw_sp *mlxsw_sp, ...@@ -3608,10 +3608,8 @@ mlxsw_sp_nexthop_group_refresh(struct mlxsw_sp *mlxsw_sp,
int i, err2, err = 0; int i, err2, err = 0;
u32 old_adj_index; u32 old_adj_index;
if (!nhgi->gateway) { if (!nhgi->gateway)
mlxsw_sp_nexthop_fib_entries_update(mlxsw_sp, nh_grp); return mlxsw_sp_nexthop_fib_entries_update(mlxsw_sp, nh_grp);
return 0;
}
for (i = 0; i < nhgi->count; i++) { for (i = 0; i < nhgi->count; i++) {
nh = &nhgi->nexthops[i]; nh = &nhgi->nexthops[i];
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册