提交 17181fb7 编写于 作者: M Mikulas Patocka 提交者: Mike Snitzer

dm thin: fix a race in thin_dtr

As long as struct thin_c is in the list, anyone can grab a reference of
it.  Consequently, we must wait for the reference count to drop to zero
*after* we remove the structure from the list, not before.
Signed-off-by: NMikulas Patocka <mpatocka@redhat.com>
Signed-off-by: NMike Snitzer <snitzer@redhat.com>
上级 d1d9220c
...@@ -3622,14 +3622,14 @@ static void thin_dtr(struct dm_target *ti) ...@@ -3622,14 +3622,14 @@ static void thin_dtr(struct dm_target *ti)
struct thin_c *tc = ti->private; struct thin_c *tc = ti->private;
unsigned long flags; unsigned long flags;
thin_put(tc);
wait_for_completion(&tc->can_destroy);
spin_lock_irqsave(&tc->pool->lock, flags); spin_lock_irqsave(&tc->pool->lock, flags);
list_del_rcu(&tc->list); list_del_rcu(&tc->list);
spin_unlock_irqrestore(&tc->pool->lock, flags); spin_unlock_irqrestore(&tc->pool->lock, flags);
synchronize_rcu(); synchronize_rcu();
thin_put(tc);
wait_for_completion(&tc->can_destroy);
mutex_lock(&dm_thin_pool_table.mutex); mutex_lock(&dm_thin_pool_table.mutex);
__pool_dec(tc->pool); __pool_dec(tc->pool);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册