提交 16b9ce83 编写于 作者: M Markus Pargmann 提交者: Antonio Quartulli

batman-adv: tvlv realloc, move error handling into if block

Instead of hiding the normal function flow inside an if block, we should
just put the error handling into the if block.
Signed-off-by: NMarkus Pargmann <mpa@pengutronix.de>
Signed-off-by: NMarek Lindner <mareklindner@neomailbox.ch>
上级 9bb21882
...@@ -819,15 +819,15 @@ static bool batadv_tvlv_realloc_packet_buff(unsigned char **packet_buff, ...@@ -819,15 +819,15 @@ static bool batadv_tvlv_realloc_packet_buff(unsigned char **packet_buff,
new_buff = kmalloc(min_packet_len + additional_packet_len, GFP_ATOMIC); new_buff = kmalloc(min_packet_len + additional_packet_len, GFP_ATOMIC);
/* keep old buffer if kmalloc should fail */ /* keep old buffer if kmalloc should fail */
if (new_buff) { if (!new_buff)
memcpy(new_buff, *packet_buff, min_packet_len); return false;
kfree(*packet_buff);
*packet_buff = new_buff; memcpy(new_buff, *packet_buff, min_packet_len);
*packet_buff_len = min_packet_len + additional_packet_len; kfree(*packet_buff);
return true; *packet_buff = new_buff;
} *packet_buff_len = min_packet_len + additional_packet_len;
return false; return true;
} }
/** /**
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册