提交 1680939e 编写于 作者: H Hangyu Hua 提交者: Mathieu Poirier

rpmsg: virtio: Fix possible double free in rpmsg_virtio_add_ctrl_dev()

vch will be free in virtio_rpmsg_release_device() when
rpmsg_ctrldev_register_device() fails. There is no need to call
kfree() again.

Fixes: c486682a ("rpmsg: virtio: Register the rpmsg_char device")
Signed-off-by: NHangyu Hua <hbh25y@gmail.com>
Tested-by: NArnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Link: https://lore.kernel.org/r/20220426060536.15594-3-hbh25y@gmail.comSigned-off-by: NMathieu Poirier <mathieu.poirier@linaro.org>
上级 c2eecefe
...@@ -851,7 +851,7 @@ static struct rpmsg_device *rpmsg_virtio_add_ctrl_dev(struct virtio_device *vdev ...@@ -851,7 +851,7 @@ static struct rpmsg_device *rpmsg_virtio_add_ctrl_dev(struct virtio_device *vdev
err = rpmsg_ctrldev_register_device(rpdev_ctrl); err = rpmsg_ctrldev_register_device(rpdev_ctrl);
if (err) { if (err) {
kfree(vch); /* vch will be free in virtio_rpmsg_release_device() */
return ERR_PTR(err); return ERR_PTR(err);
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册