提交 11dc0fb8 编写于 作者: K Kuniyuki Iwashima 提交者: Zheng Zengkai

sysctl: Fix data races in proc_dointvec_minmax().

stable inclusion
from stable-v5.10.132
commit 71ddde27c2eba5223c350513dd7d524c3cf1d6a4
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I5YS3T

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=71ddde27c2eba5223c350513dd7d524c3cf1d6a4

--------------------------------

[ Upstream commit f613d86d ]

A sysctl variable is accessed concurrently, and there is always a chance
of data-race.  So, all readers and writers need some basic protection to
avoid load/store-tearing.

This patch changes proc_dointvec_minmax() to use READ_ONCE() and
WRITE_ONCE() internally to fix data-races on the sysctl side.  For now,
proc_dointvec_minmax() itself is tolerant to a data-race, but we still
need to add annotations on the other subsystem's side.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: NKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
Signed-off-by: NSasha Levin <sashal@kernel.org>
Signed-off-by: NZheng Zengkai <zhengzengkai@huawei.com>
Acked-by: NXie XiuQi <xiexiuqi@huawei.com>
上级 85243673
...@@ -965,7 +965,7 @@ static int do_proc_dointvec_minmax_conv(bool *negp, unsigned long *lvalp, ...@@ -965,7 +965,7 @@ static int do_proc_dointvec_minmax_conv(bool *negp, unsigned long *lvalp,
if ((param->min && *param->min > tmp) || if ((param->min && *param->min > tmp) ||
(param->max && *param->max < tmp)) (param->max && *param->max < tmp))
return -EINVAL; return -EINVAL;
*valp = tmp; WRITE_ONCE(*valp, tmp);
} }
return 0; return 0;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册