提交 0e28bf93 编写于 作者: A Anna-Maria Gleixner 提交者: David S. Miller

net: mvneta: Remove superfluous SMP function call

Since commit 3b9d6da6 ("cpu/hotplug: Fix rollback during error-out
in __cpu_disable()") it is ensured that callbacks of CPU_ONLINE and
CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP
function calls are no longer required.

Replace smp_call_function_single() with a direct call to
mvneta_percpu_enable() or mvneta_percpu_disable(). The functions do
not require to be called with interrupts disabled, therefore the
smp_call_function_single() calling convention is not preserved.

Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: netdev@vger.kernel.org
Signed-off-by: NAnna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 ce24c2b8
...@@ -3354,8 +3354,7 @@ static int mvneta_percpu_notifier(struct notifier_block *nfb, ...@@ -3354,8 +3354,7 @@ static int mvneta_percpu_notifier(struct notifier_block *nfb,
/* Enable per-CPU interrupts on the CPU that is /* Enable per-CPU interrupts on the CPU that is
* brought up. * brought up.
*/ */
smp_call_function_single(cpu, mvneta_percpu_enable, mvneta_percpu_enable(pp);
pp, true);
/* Enable per-CPU interrupt on the one CPU we care /* Enable per-CPU interrupt on the one CPU we care
* about. * about.
...@@ -3387,8 +3386,7 @@ static int mvneta_percpu_notifier(struct notifier_block *nfb, ...@@ -3387,8 +3386,7 @@ static int mvneta_percpu_notifier(struct notifier_block *nfb,
/* Disable per-CPU interrupts on the CPU that is /* Disable per-CPU interrupts on the CPU that is
* brought down. * brought down.
*/ */
smp_call_function_single(cpu, mvneta_percpu_disable, mvneta_percpu_disable(pp);
pp, true);
break; break;
case CPU_DEAD: case CPU_DEAD:
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册