提交 0d0f9dfb 编写于 作者: R Roland Dreier 提交者: Nicholas Bellinger

target: Don't return success from module_init() if setup fails

If the call to core_dev_release_virtual_lun0() fails, then nothing
sets ret to anything other than 0, so even though everything is
torn down and freed, target_core_init_configfs() will seem to succeed
and the module will be loaded.  Fix this by passing the return value
on up the chain.
Signed-off-by: NRoland Dreier <roland@purestorage.com>
Cc: stable@vger.kernel.org
Signed-off-by: NNicholas Bellinger <nab@linux-iscsi.org>
上级 dea5f099
...@@ -3206,7 +3206,8 @@ static int __init target_core_init_configfs(void) ...@@ -3206,7 +3206,8 @@ static int __init target_core_init_configfs(void)
if (ret < 0) if (ret < 0)
goto out; goto out;
if (core_dev_setup_virtual_lun0() < 0) ret = core_dev_setup_virtual_lun0();
if (ret < 0)
goto out; goto out;
return 0; return 0;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册