提交 0aedc880 编写于 作者: S Simon Ser

drm/atomic-helper: print message on driver connector check failure

Sometimes drivers are missing logs when they return EINVAL.
Printing the failure here in common code can help understand where
EINVAL is coming from.

All other atomic_check() calls in this file already have similar
logging.

v2: add missing newlines
Signed-off-by: NSimon Ser <contact@emersion.fr>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: NLyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220829151451.152114-1-contact@emersion.fr
上级 981f0929
...@@ -702,8 +702,12 @@ drm_atomic_helper_check_modeset(struct drm_device *dev, ...@@ -702,8 +702,12 @@ drm_atomic_helper_check_modeset(struct drm_device *dev,
if (funcs->atomic_check) if (funcs->atomic_check)
ret = funcs->atomic_check(connector, state); ret = funcs->atomic_check(connector, state);
if (ret) if (ret) {
drm_dbg_atomic(dev,
"[CONNECTOR:%d:%s] driver check failed\n",
connector->base.id, connector->name);
return ret; return ret;
}
connectors_mask |= BIT(i); connectors_mask |= BIT(i);
} }
...@@ -745,9 +749,13 @@ drm_atomic_helper_check_modeset(struct drm_device *dev, ...@@ -745,9 +749,13 @@ drm_atomic_helper_check_modeset(struct drm_device *dev,
if (funcs->atomic_check) if (funcs->atomic_check)
ret = funcs->atomic_check(connector, state); ret = funcs->atomic_check(connector, state);
if (ret) if (ret) {
drm_dbg_atomic(dev,
"[CONNECTOR:%d:%s] driver check failed\n",
connector->base.id, connector->name);
return ret; return ret;
} }
}
/* /*
* Iterate over all connectors again, and add all affected bridges to * Iterate over all connectors again, and add all affected bridges to
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册