提交 02862341 编写于 作者: J Julia Lawall 提交者: David S. Miller

net: phy: mdio: add missing of_node_put

for_each_available_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
@@

 for_each_available_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
(
   return child;
|
+  of_node_put(child);
?  return ...;
)
   ...
 }
// </smpl>
Signed-off-by: NJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 447ed736
...@@ -113,12 +113,14 @@ static int mdio_mux_mmioreg_probe(struct platform_device *pdev) ...@@ -113,12 +113,14 @@ static int mdio_mux_mmioreg_probe(struct platform_device *pdev)
if (!iprop || len != sizeof(uint32_t)) { if (!iprop || len != sizeof(uint32_t)) {
dev_err(&pdev->dev, "mdio-mux child node %s is " dev_err(&pdev->dev, "mdio-mux child node %s is "
"missing a 'reg' property\n", np2->full_name); "missing a 'reg' property\n", np2->full_name);
of_node_put(np2);
return -ENODEV; return -ENODEV;
} }
if (be32_to_cpup(iprop) & ~s->mask) { if (be32_to_cpup(iprop) & ~s->mask) {
dev_err(&pdev->dev, "mdio-mux child node %s has " dev_err(&pdev->dev, "mdio-mux child node %s has "
"a 'reg' value with unmasked bits\n", "a 'reg' value with unmasked bits\n",
np2->full_name); np2->full_name);
of_node_put(np2);
return -ENODEV; return -ENODEV;
} }
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册