• S
    KVM: x86: Do not mark all registers as avail/dirty during RESET/INIT · ff8828c8
    Sean Christopherson 提交于
    Do not blindly mark all registers as available+dirty at RESET/INIT, and
    instead rely on writes to registers to go through the proper mutators or
    to explicitly mark registers as dirty.  INIT in particular does not blindly
    overwrite all registers, e.g. select bits in CR0 are preserved across INIT,
    thus marking registers available+dirty without first reading the register
    from hardware is incorrect.
    
    In practice this is a benign bug as KVM doesn't let the guest control CR0
    bits that are preserved across INIT, and all other true registers are
    explicitly written during the RESET/INIT flows.  The PDPTRs and EX_INFO
    "registers" are not explicitly written, but accessing those values during
    RESET/INIT is nonsensical and would be a KVM bug regardless of register
    caching.
    
    Fixes: 66f7b72e ("KVM: x86: Make register state after reset conform to specification")
    [sean: !!! NOT FOR STABLE !!!]
    Signed-off-by: NSean Christopherson <seanjc@google.com>
    Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
    Message-Id: <20210921000303.400537-4-seanjc@google.com>
    Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
    ff8828c8
vmx.c 224.8 KB