• V
    HID: thingm: refactor blink(1) support · f70ed8a6
    Vivien Didelot 提交于
    This patch refactors the way the thingm driver registers a blink(1) LED.
    In order to make the driver simpler and more standard, drop the "rgb"
    sysfs attribute and create one instance of LED class per RGB channel.
    
    Actually, the name of the LED class instance registered for a blink(1)
    device is "blink1::ABCD", where ABCD is the last 4 chars of the serial
    number. The driver now registers 3 instances per RGB chip, named
    "thingmX:{red,green,blue}:ledY" where X is the hidraw minor number and Y
    is the RGB chip number (as seen by the firmware).
    
    This patch also uses work queues to defer calls with the device, which
    now allows triggers to work as expected with this LED device.
    
    Also remove the brightness structure field and the brightness_get
    backend, as it is already handled by the LED class, and changes the
    prefix of functions and structures to thingm_ to match the driver name.
    Signed-off-by: NVivien Didelot <vivien.didelot@savoirfairelinux.com>
    Signed-off-by: NJiri Kosina <jkosina@suse.cz>
    f70ed8a6
hid-thingm.c 6.8 KB