• A
    perf trace: Beautify 'fsconfig' arguments · dcc6fd64
    Arnaldo Carvalho de Melo 提交于
    Use existing beautifiers for the first arg, fd, assigned using the
    heuristic that looks for syscall arg names and associates SCA_FD with
    'fd' named argumes, and wire up the recently introduced fsconfig cmd
    table generator.
    
    Now it should be possible to just use:
    
       perf trace -e fsconfig
    
    As root and see all fsconfig syscalls with its args beautified, more
    work needed to look at the command and according to it handle the 'key',
    'value' and 'aux' args, using the 'fcntl' and 'futex' beautifiers as a
    starting point to see how to suppress sets of these last three args that
    may not be used by the 'cmd' arg, etc.
    
      # cat sys_fsconfig.c
      #define _GNU_SOURCE         /* See feature_test_macros(7) */
      #include <unistd.h>
      #include <sys/syscall.h>   /* For SYS_xxx definitions */
      #include <fcntl.h>
    
      #define __NR_fsconfig 431
    
      enum fsconfig_command {
      	FSCONFIG_SET_FLAG	= 0,	/* Set parameter, supplying no value */
      	FSCONFIG_SET_STRING	= 1,	/* Set parameter, supplying a string value */
      	FSCONFIG_SET_BINARY	= 2,	/* Set parameter, supplying a binary blob value */
      	FSCONFIG_SET_PATH	= 3,	/* Set parameter, supplying an object by path */
      	FSCONFIG_SET_PATH_EMPTY	= 4,	/* Set parameter, supplying an object by (empty) path */
      	FSCONFIG_SET_FD		= 5,	/* Set parameter, supplying an object by fd */
      	FSCONFIG_CMD_CREATE	= 6,	/* Invoke superblock creation */
      	FSCONFIG_CMD_RECONFIGURE = 7,	/* Invoke superblock reconfiguration */
      };
    
      static inline int sys_fsconfig(int fd, int cmd, const char *key, const void *value, int aux)
      {
      	syscall(__NR_fsconfig, fd, cmd, key, value, aux);
      }
    
      int main(int argc, char *argv[])
      {
      	int fd = 0, aux = 0;
    
      	open("/foo", 0);
      	sys_fsconfig(fd++, FSCONFIG_SET_FLAG,	     "/foo1", "/bar1", aux++);
      	sys_fsconfig(fd++, FSCONFIG_SET_STRING,	     "/foo2", "/bar2", aux++);
      	sys_fsconfig(fd++, FSCONFIG_SET_BINARY,	     "/foo3", "/bar3", aux++);
      	sys_fsconfig(fd++, FSCONFIG_SET_PATH,	     "/foo4", "/bar4", aux++);
      	sys_fsconfig(fd++, FSCONFIG_SET_PATH_EMPTY,  "/foo5", "/bar5", aux++);
      	sys_fsconfig(fd++, FSCONFIG_SET_FD,	     "/foo6", "/bar6", aux++);
      	sys_fsconfig(fd++, FSCONFIG_CMD_CREATE,	     "/foo7", "/bar7", aux++);
      	sys_fsconfig(fd++, FSCONFIG_CMD_RECONFIGURE, "/foo8", "/bar8", aux++);
      	return 0;
      }
      # trace -e fsconfig ./sys_fsconfig
      fsconfig(0, FSCONFIG_SET_FLAG, 0x40201b, 0x402015, 0) = -1 EINVAL (Invalid argument)
      fsconfig(1, FSCONFIG_SET_STRING, 0x402027, 0x402021, 1) = -1 EINVAL (Invalid argument)
      fsconfig(2, FSCONFIG_SET_BINARY, 0x402033, 0x40202d, 2) = -1 EINVAL (Invalid argument)
      fsconfig(3, FSCONFIG_SET_PATH, 0x40203f, 0x402039, 3) = -1 EBADF (Bad file descriptor)
      fsconfig(4, FSCONFIG_SET_PATH_EMPTY, 0x40204b, 0x402045, 4) = -1 EBADF (Bad file descriptor)
      fsconfig(5, FSCONFIG_SET_FD, 0x402057, 0x402051, 5) = -1 EINVAL (Invalid argument)
      fsconfig(6, FSCONFIG_CMD_CREATE, 0x402063, 0x40205d, 6) = -1 EINVAL (Invalid argument)
      fsconfig(7, FSCONFIG_CMD_RECONFIGURE, 0x40206f, 0x402069, 7) = -1 EINVAL (Invalid argument)
      #
    
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Luis Cláudio Gonçalves <lclaudio@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Link: https://lkml.kernel.org/n/tip-fb04b76cm59zfuv1wzu40uxy@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
    dcc6fd64
Makefile.perf 34.4 KB