• A
    rbd: add a warning in bio_chain_clone_range() · f5400b7a
    Alex Elder 提交于
    Add a warning in bio_chain_clone_range() to help a user determine
    what exactly might have led to a failure.  There is only one; please
    say something if you disagree with the following reasoning.
    
    There are three places this can return abnormally:
        - Initially, if there is nothing to clone.  It turns out that
          right now this cannot happen anyway.  The test is in place
          because the code below it doesn't work if those conditions
          don't hold.  As such they could be assertions but since I can
          return a null to indicate an error I just do that instead.
          I have not added a warning here because it won't happen.
        - While processing bio's, if none remain but there are supposed
          to be more bytes to clone.  Here I have added a warning.
        - If bio_clone_range() returns a null pointer.  That function
          will have already produced a warning (at least the first
          time, via WARN_ON_ONCE()) to distinguish the cause of the
          error.  The only exception is memory exhaustion, and I'd
          rather not pepper the code with warnings in all those spots.
          So no warning is added in that place.
    Signed-off-by: NAlex Elder <elder@inktank.com>
    Reviewed-by: NJosh Durgin <josh.durgin@inktank.com>
    f5400b7a
rbd.c 90.4 KB