-
由 Don Brace 提交于
The driver is using two MACROs which seemingly are looking in the wrong location for the device_flags returned from CISS_REPORT_PHYS. Both MACROs, NON_DISK_PHYS_DEV and PHYS_IOACCEL, are using the pointer returned from figure_lunaddrbytes which is the address of the LUN.lunid element in the extended CISS_REPORT_PHYS. But the MACROS are using offsets beyond the range of the element (offset 17 of an 8 byte element). These MACROs actually are looking at the correct location but they fail static checker analysis. It also will not work if any new elements are added to the extended LUN structure. Change the code to use the structure elements directly since this MACRO is only used in one location. Reported-by: NDan Carpenter <dan.carpenter@oracle.com> Reviewed-by: NScott Teel <scott.teel@pmcs.com> Reviewed-by: NJustin Lindley <justin.lindley@pmcs.com> Reviewed-by: NKevin Barnett <kevin.barnett@pmcs.com> Reviewed-by: NTomas Henzl <thenzl@redhat.com> Reviewed-by: NHannes Reinecke <hare@suse.de> Signed-off-by: NDon Brace <don.brace@pmcs.com> Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
f2039b03