• O
    net: remove noblock parameter from skb_recv_datagram() · f4b41f06
    Oliver Hartkopp 提交于
    skb_recv_datagram() has two parameters 'flags' and 'noblock' that are
    merged inside skb_recv_datagram() by 'flags | (noblock ? MSG_DONTWAIT : 0)'
    
    As 'flags' may contain MSG_DONTWAIT as value most callers split the 'flags'
    into 'flags' and 'noblock' with finally obsolete bit operations like this:
    
    skb_recv_datagram(sk, flags & ~MSG_DONTWAIT, flags & MSG_DONTWAIT, &rc);
    
    And this is not even done consistently with the 'flags' parameter.
    
    This patch removes the obsolete and costly splitting into two parameters
    and only performs bit operations when really needed on the caller side.
    
    One missing conversion thankfully reported by kernel test robot. I missed
    to enable kunit tests to build the mctp code.
    Reported-by: Nkernel test robot <lkp@intel.com>
    Signed-off-by: NOliver Hartkopp <socketcan@hartkopp.net>
    Signed-off-by: NDavid S. Miller <davem@davemloft.net>
    f4b41f06
raw.c 26.1 KB