• J
    serdev: ttyport: add missing receive_buf sanity checks · eb281683
    Johan Hovold 提交于
    The receive_buf tty-port callback should return the number of bytes
    accepted and must specifically never return a negative errno (or a value
    larger than the buffer size) to the tty layer.
    
    A serdev driver not providing a receive_buf callback would currently
    cause the flush_to_ldisc() worker to spin in a tight loop when the tty
    buffer pointers are incremented with -EINVAL (-22) after data has been
    received.
    
    A serdev driver occasionally returning a negative errno (or a too large
    byte count) could cause information leaks or crashes when accessing
    memory outside the tty buffers in consecutive callbacks.
    
    Fixes: cd6484e1 ("serdev: Introduce new bus for serial attached devices")
    Cc: stable <stable@vger.kernel.org>	# 4.11
    Signed-off-by: NJohan Hovold <johan@kernel.org>
    Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    eb281683
serdev-ttyport.c 6.9 KB